Increase MSRV to 1.60 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to use of a 1.53 feature in color_quant (#142) the MSRV was already de-facto higher. Most libraries don't support anything below 1.56 (2021 edition) and 99% of Rust users are on 1.63 or later.
I suggest bumping to 1.60, because this can be done without immediately breaking users on older Rust versions. When a crate version uses the new
dep:feature syntax, it ends up having a new field in the crates.io registry index, which causes Cargo versions older than 1.60 to silently skip and ignore it, and fall back to an older version if possible. So a release bumped to MSRV 1.60+ will be invisible to users of older Rust versions.