New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🫶 Add support encoding.TextUnmarshaler
#123
Conversation
@ilyakaznacheev, what do you think about it? |
Thanks, I'll check |
Seems definitely useful to me as well. For any type that inherently supports |
@ilyakaznacheev, I am writing to inquire about the progress of the PR review. I understand that the review process can take time, but I wanted to check if there are any issues or problems that may be causing a delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for this case.
@ilyakaznacheev, done ✅ |
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 93.76% 92.79% -0.97%
==========================================
Files 1 1
Lines 353 361 +8
==========================================
+ Hits 331 335 +4
- Misses 13 15 +2
- Partials 9 11 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ilyakaznacheev, when can we expect a new release? |
Add support
encoding.TextUnmarshaler
for example:Custom type
zapcore.Level
from zap implements interfaceencoding.TextUnmarshaler
.P.S. I am confident that this commit will be beneficial for the community.