TryFromPrimitive ignores default attributes #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If exhaustive behaviour is desired, FromPrimitive should be derived instead. Because these traits are exclusive, there's no room for ambiguity here - either TryFromPrimitive is derived and defaults are ignored, or FromPrimitive is derived and defaults are paid attention to. This is, however, a breaking change, as it changes the implementation of TryFromPrimitive significantly. Fixes #75 Fixes #31
This isn't necessarily ready for release, but we're making a breaking change so we should bump so we don't forget whenever the time for the next release comes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If exhaustive behaviour is desired, FromPrimitive should be derived
instead.
Because these traits are exclusive, there's no room for ambiguity here -
either TryFromPrimitive is derived and defaults are ignored, or
FromPrimitive is derived and defaults are paid attention to.
This is, however, a breaking change, as it changes the implementation of
TryFromPrimitive significantly.
Fixes #75
Fixes #31