New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated development dependencies #138
Conversation
@@ -58,7 +58,7 @@ | |||
"ember-cli-htmlbars": "^6.1.1", | |||
"ember-cli-typescript": "^5.2.1", | |||
"ember-element-helper": "^0.6.1", | |||
"ember-modifier": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine that listing ember-modifier@v4
will be a breaking change for production apps, because teams will need time to address deprecation warnings from v3
. (I'm assuming that teams prefer having a single version for every installed package.)
I'll update ember-modifier
to v4
later (definitely after ember-container-query@v3.0.0
is released).
"peerDependencies": { | ||
"ember-source": "^3.28.0 || ^4.0.0" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines were added when I ran ember-cli-update
to update ember-cli
and ember-source
to v4.9
.
I wasn't sure if the lines mean a breaking change for consuming apps below Ember 3.28, so I removed them from this pull request. (Consider adding them back after ember-container-query@v3.0.0
is released.)
More information at ember-cli/ember-cli#10024.
Description