Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated development dependencies #138

Merged
merged 6 commits into from Dec 13, 2022
Merged

Updated development dependencies #138

merged 6 commits into from Dec 13, 2022

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Dec 13, 2022

Description

Package                          Current Wanted  Latest  Package Type    URL
@typescript-eslint/eslint-plugin 5.45.0  5.46.1  5.46.1  devDependencies https://github.com/typescript-eslint/typescript-eslint#readme
@typescript-eslint/parser        5.45.0  5.46.1  5.46.1  devDependencies https://github.com/typescript-eslint/typescript-eslint#readme
d3-array                         3.2.0   3.2.1   3.2.1   devDependencies https://d3js.org/d3-array/
ember-a11y-testing               5.0.0   5.1.0   5.1.0   devDependencies https://github.com/ember-a11y/ember-a11y-testing#readme
ember-cli                        4.8.0   4.8.0   4.9.2   devDependencies https://cli.emberjs.com/release/
ember-modifier                   3.2.7   3.2.7   4.0.0   dependencies    https://github.com/ember-modifier/ember-modifier#readme
ember-source                     4.8.2   4.8.3   4.9.2   devDependencies https://emberjs.com/
ember-template-lint              5.0.2   5.2.0   5.2.0   devDependencies https://github.com/ember-template-lint/ember-template-lint
eslint                           8.28.0  8.29.0  8.29.0  devDependencies https://eslint.org
eslint-plugin-n                  15.5.1  15.6.0  15.6.0  devDependencies https://github.com/eslint-community/eslint-plugin-n#readme
prettier                         2.8.0   2.8.1   2.8.1   devDependencies https://prettier.io
stylelint                        14.15.0 14.16.0 14.16.0 devDependencies https://stylelint.io

@ijlee2 ijlee2 added the enhance: dependency Issue asks for a new or updated dependency label Dec 13, 2022
@ijlee2 ijlee2 changed the title Updated dependencies Updated development dependencies Dec 13, 2022
@@ -58,7 +58,7 @@
"ember-cli-htmlbars": "^6.1.1",
"ember-cli-typescript": "^5.2.1",
"ember-element-helper": "^0.6.1",
"ember-modifier": "^4.0.0",
Copy link
Owner Author

@ijlee2 ijlee2 Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine that listing ember-modifier@v4 will be a breaking change for production apps, because teams will need time to address deprecation warnings from v3. (I'm assuming that teams prefer having a single version for every installed package.)

I'll update ember-modifier to v4 later (definitely after ember-container-query@v3.0.0 is released).

Comment on lines 148 to 150
"peerDependencies": {
"ember-source": "^3.28.0 || ^4.0.0"
},
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines were added when I ran ember-cli-update to update ember-cli and ember-source to v4.9.

I wasn't sure if the lines mean a breaking change for consuming apps below Ember 3.28, so I removed them from this pull request. (Consider adding them back after ember-container-query@v3.0.0 is released.)

More information at ember-cli/ember-cli#10024.

@ijlee2 ijlee2 marked this pull request as ready for review December 13, 2022 11:01
@ijlee2 ijlee2 merged commit 50ca912 into main Dec 13, 2022
@ijlee2 ijlee2 deleted the update-dependencies branch December 13, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: dependency Issue asks for a new or updated dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant