Update recipes to use a base_url variable to improve readability
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenrobson
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Looks good to me. The base URL is made up of a standard URL plus a recipe identifier so you could generate it like:
recipeId="0001-mvm-image"
base_url = f"https://iiif.io/api/cookbook/recipe/{recipeId}"
but looking through the code you only reference it once so probably not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up on an idea I used during my dogfooding of the "Introduction to
iiif-prezi3" lightning talk: due to the structure of the recipes, there are a lot ofidfields that have a common start, so this PR adds abase_urlvariable and uses it in the various bits of manifest data, meaning that the resulting code looks a bit less cluttered (IMO)