Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update datamodel-code-generator #158

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Update datamodel-code-generator #158

merged 4 commits into from
Jan 27, 2023

Conversation

digitaldogsbody
Copy link
Member

@digitaldogsbody digitaldogsbody commented Jan 27, 2023 •
edited

This PR:

  • adds datamodel-code-generator to the development requirements of the library with a minimum version of 0.16.1
  • updates the skeleton regeneration script to use the newly added --remove-special-field-name-prefix option
  • confirms that it has fixed the issue with accidental private variables where @id became _id.
  • includes a regenerated skeleton file
  • removes the previous patch for the _id issue as it is no longer required

Closes #156

@digitaldogsbody digitaldogsbody merged commit d002f8c into main Jan 27, 2023
@digitaldogsbody digitaldogsbody deleted the update_datamodel branch January 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenrobson glenrobson glenrobson approved these changes

@giacomomarchioro giacomomarchioro Awaiting requested review from giacomomarchioro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update datamodel-code-generator to version 0.17.0
2 participants
@digitaldogsbody @glenrobson