Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use async trait to refactor the service #1

Closed
wants to merge 1 commit into from
Closed

use async trait to refactor the service #1

wants to merge 1 commit into from

Conversation

rainj-me
Copy link
Contributor

No description provided.

@ihciah
Copy link
Owner

ihciah commented Jul 1, 2023 •
edited

  1. Current trait definition is compatible with async_trait macros(#[async_trait(?Send)])(Precisely, compatible with the implementation that generate BoxFuture); while modified version are not compatible with GAT version.
  2. Using GAT style is more efficient than async_trait macros.
  3. Using #[async_trait] requires Send which is not our goal.

@ihciah
Copy link
Owner

ihciah commented Nov 10, 2023

Close in favor of #2

@ihciah ihciah closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rainj-me @ihciah