Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gofmt on session.go #74

Closed
wants to merge 1 commit into from
Closed

Conversation

scottmmjackson
Copy link
Contributor

Ran a gofmt checker across the repo and session.go popped up.

After this change, the entire repo should be consistently gofmtted.

https://golang.org/misc/git/pre-commit - useful for contributors

https://github.com/google/gopacket/blob/master/.travis.gofmt.sh - could be a good way to enforce gofmt in travis

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.385% when pulling 57f282d on scottmmjackson:sj-gofmt into 7e107b4 on igm:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.385% when pulling 57f282d on scottmmjackson:sj-gofmt into 7e107b4 on igm:master.

@igm
Copy link
Owner

igm commented Jun 21, 2019

Thanks @scottmmjackson for pointing this out. The gofmt behaviour has changed in 1.11 (see golang/go#26228). So I assume you are using >1.11 and that's why you see the difference in formatting and the last commit of that file was before 1.11.

I'm not 100% sure about pre-commit hook as it depends on go version the user is using on the machine, but travis check seems fine. So could you please include travis CI config file update in this PR so that we use 1.12 together with gofmt?

@scottmmjackson
Copy link
Contributor Author

Will do, busy day at work so I'll try to get around to it this afternoon EST

@igm igm closed this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants