Convert all env values to strings

[finishes #154745470] Signed-off-by: Elena Sharma <esharma@pivotal.io>
idoru · Apr 4, 2018 · 6e58728 · 6e58728
1 parent caf7cb3
commit 6e58728
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/messages/app_manifest_message.rb b/app/messages/app_manifest_message.rb
@@ -96,8 +96,8 @@ def app_update_attribute_mapping
 
     def env_update_attribute_mapping
       mapping = {}
-      if requested?(:env)
-        mapping[:var] = env
+      if requested?(:env) && env.is_a?(Hash)
+        mapping[:var] = env.each { |k, v| env[k] = v.to_s }
       end
       mapping
     end

diff --git a/spec/unit/messages/app_manifest_message_spec.rb b/spec/unit/messages/app_manifest_message_spec.rb
@@ -609,7 +609,7 @@ module VCAP::CloudController
         message = AppManifestMessage.create_from_http_request(parsed_yaml)
         expect(message).to be_valid
         expect(message.app_update_environment_variables_message.var).
-          to eq({ foo: 'bar', baz: 4.44444444444, qux: false })
+          to eq({ foo: 'bar', baz: '4.44444444444', qux: 'false' })
       end
     end
   end