fix the expected/actual value ordering in a few unit test asserts #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
- Coverage 73.35% 73.23% -0.12%
==========================================
Files 68 68
Lines 8721 8721
==========================================
- Hits 6397 6387 -10
- Misses 2324 2334 +10
Continue to review full report at Codecov.
|
|
Not sure what's going on with the coverage results - this shouldn't effect coverage at all, even less so in BZip2OutputStream |
|
No, there is something really odd going on. I have tried fixing it by reducing the amount of test coverage results being uploaded, but it's still bonkers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather trivial, but still
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.