Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ZipAESStream throw ZipException instead of Exception when the AES auth code is wrong #577

Merged
merged 1 commit into from Feb 21, 2021

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Feb 14, 2021

spin off from my question about what exception type it should use in #576 (not sure if there's a more specific exception type about to use, but plain Exception seems wrong)

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel piksel merged commit 3617fb9 into icsharpcode:master Feb 21, 2021
@Numpsy Numpsy deleted the rw/eas_throw_zipexcept branch March 1, 2021 12:35
HowToDoThis added a commit to HowToDoThis/SharpZipLib that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants