Short progress bar #237
Open
Short progress bar #237
+80
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Attempt to strip the download path - show only the path below - truncate in the middle if longer than 60 not 96 chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on removing the download-path from the progress-bar. Closes #173 potentially. Aim is to shorten the printed out filenames. Relevant on shorter/smaller terminal sizes.
I'm not really sure if I like this change. I did not touch the behaviour of
--only-print-filenames. I updated (most of the) tests accordingly and I'm not sure why some are failing now. Anyways I wanted to put this on for discussion. Some changes come from a linter run afterwards, so just code reformatting...What do you think about this change?
PS: I also don't really like the more or less copy&paste but slightly different handling for photos vs. Live Photos and the deduce logic. Maybe worth some refactoring. But that's another issue...