-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm: enable events loop #459
Merged
Merged
Commits on Jan 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4d459ca - Browse repository at this point
Copy the full SHA 4d459caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26586f8 - Browse repository at this point
Copy the full SHA 26586f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0e7eda - Browse repository at this point
Copy the full SHA d0e7edaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d71e32a - Browse repository at this point
Copy the full SHA d71e32aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6f18e6 - Browse repository at this point
Copy the full SHA c6f18e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c47c8 - Browse repository at this point
Copy the full SHA 66c47c8View commit details
Commits on Jan 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 542fa1b - Browse repository at this point
Copy the full SHA 542fa1bView commit details -
main: disable set_cursor_grab() call on wasm to get further until Poi…
…nter Lock is available
Configuration menu - View commit details
-
Copy full SHA for f118953 - Browse repository at this point
Copy the full SHA f118953View commit details -
Revert "Log when entering/exiting render/events loops"
This reverts commit 542fa1b.
Configuration menu - View commit details
-
Copy full SHA for 1dca9fd - Browse repository at this point
Copy the full SHA 1dca9fdView commit details
Commits on Jan 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 991b5f1 - Browse repository at this point
Copy the full SHA 991b5f1View commit details -
Failed attempt at fixing use of moved value
error[E0716]: temporary value dropped while borrowed --> src/main.rs:332:24 | 332 | let winit_window = Box::leak(Box::new(glutin_window)).borrow().window(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------- temporary value is freed at the end of this statement | | | creates a temporary which is freed while still in use | argument requires that borrow lasts for `'static` error[E0382]: use of moved value: `glutin_window` --> src/main.rs:437:21 | 330 | let glutin_window = RefCell::new(Box::leak(Box::new(glutin_window))); | ------------- move occurs because `glutin_window` has type `RefCell<&mut ContextWrapper<PossiblyCurrent, winit::window::Window>>`, which does not implement the `Copy` trait 331 | #[cfg(not(target_arch = "wasm32"))] 332 | let winit_window = Box::leak(Box::new(glutin_window)).borrow().window(); | ------------- value moved here ... 437 | events_loop.run(move |event, _event_loop, control_flow| { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ value used here after move ... 458 | glutin_window.borrow().resize(physical_size); | ------------- use occurs due to use in closure error: aborting due to 2 previous errors
Configuration menu - View commit details
-
Copy full SHA for 8f78ec4 - Browse repository at this point
Copy the full SHA 8f78ec4View commit details -
Revert "Failed attempt at fixing use of moved value"
This reverts commit 8f78ec4.
Configuration menu - View commit details
-
Copy full SHA for 3e672ad - Browse repository at this point
Copy the full SHA 3e672adView commit details
Commits on Jan 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4350a01 - Browse repository at this point
Copy the full SHA 4350a01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e57cca - Browse repository at this point
Copy the full SHA 8e57ccaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.