Support a fifth screen #1627
Support a fifth screen #1627
Conversation
|
I'm not sure if I covered all the ground. I tried to test build it locally, but I got an error |
| @@ -62,6 +62,10 @@ | |||
| "mod": "mod1", | |||
| "key": "q" | |||
| }, | |||
| "focus-screen-5": { | |||
| "mod": "mod1", | |||
| "key": "g" | |||
There was a problem hiding this comment.
Just assigned a random new key that I see has not been assigned to any other action yet.
| @@ -17,7 +17,7 @@ class HotKeyManagerTests: QuickSpec { | |||
| it("has the right number of screens") { | |||
| let keyMapping = HotKeyManager<SIApplication>.hotKeyNameToDefaultsKey() | |||
| let screenCommands = keyMapping.filter { $0[1].hasPrefix(CommandKey.focusScreenPrefix.rawValue) } | |||
| expect(screenCommands.count).to(equal(6)) | |||
| expect(screenCommands.count).to(equal(7)) | |||
There was a problem hiding this comment.
Not sure if this is the right change (can't run tests locally due to build failure) though it seemed relevant.
|
OK, I figured out that the build was failing because it was trying to invoke I wonder if the version of the SDK used to build the app is too new or something. |
|
Thanks! It seems that the test pipeline cannot be run at the moment. Maybe it's the case for all PRs? |
|
I think that problem is unrelated, so I'll merge and deal with the build later. |
As mentioned in #1584, MacOS now supports up to 5 displays. This PR adds support for interacting with a fifth screen.