Skip to content

Commit

Permalink
fix: disable additional rules handled by TypeScript compiler (#283)
Browse files Browse the repository at this point in the history
Rules disabled: `no-import-assign`, `no-setter-return`, `import/no-named-as-default-member`

While this could be seen as a breaking change, in reality the TypeScript code would not compile. The code must adhere to these rules already. So the impact of this change is simply reducing unnecessary noise within linting errors (and leaving it to the TypeScript compiler, which is better suited).
  • Loading branch information
lucasvazq committed Mar 19, 2022
1 parent 221be43 commit 11185a9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/shared.js
Expand Up @@ -264,15 +264,18 @@ module.exports = {
'no-dupe-class-members': 'off',
'no-dupe-keys': 'off',
'no-func-assign': 'off',
'no-import-assign': 'off',
'no-new-symbol': 'off',
'no-obj-calls': 'off',
'no-redeclare': 'off',
'no-setter-return': 'off',
'no-this-before-super': 'off',
'no-undef': 'off',
'no-unreachable': 'off',
'no-unsafe-negation': 'off',
'valid-typeof': 'off',
'import/named': 'off',
'import/no-named-as-default-member': 'off',
'import/no-unresolved': 'off',
},
},
Expand Down

0 comments on commit 11185a9

Please sign in to comment.