Fix Pino HTTP types

[0xslipk]

This PR will fix the problem with pino and pino-http types.

#699
pinojs/pino-http#175

[0xslipk]

Hi @iamolegga please take a look of this PR. I did all the changes as we discussed it in #699

[iamolegga]

Hey @jarcodallo , thanks! It looks like it needs to be rebased again (thanks, dependabot) 😅

And I'm still wondering do we really need to include pino in deps here as it goes as dep of pino-http. I'm going to fork your branch and exclude it from the deps to see the result for the test project if it will work without pino as a direct dep of this lib

[0xslipk]

Hey @jarcodallo , thanks! It looks like it needs to be rebased again (thanks, dependabot) 😅 And I'm still wondering do we really need to include pino in deps here as it goes as dep of pino-http. I'm going to fork your branch and exclude it from the deps to see the result for the test project if it will work without pino as a direct dep of this lib

OMG! remove the deps bot hahaha (flipping the table meme here).
I included it, because the @nestjs/platform-fastify install an old version of pino that need the types from @types/pino package. I will check if everything work w/o pino in devDeps. Thanks

[0xslipk]

@iamolegga I removed pino from the devDeps and get this error:

With pino installed as devDep:

[iamolegga]

Ok then, let's keep pino in deps, I believe we can drop it when platform-fastify will be updated.

Thank you very much for this improvement! Merging!

[0xslipk]

Ok then, let's keep pino in deps, I believe we can drop it when platform-fastify will be updated.

Thank you very much for this improvement! Merging!

Happy to help 🚀

[iamolegga]

@jarcodallo now I'm thinking which version update should be for this update. major, minor, fix 🤔 API of this lib didn't change, but imports/types of underlying logger have changed slightly

[0xslipk]

@jarcodallo now I'm thinking which version update should be for this update. major, minor, fix 🤔 API of this lib didn't change, but imports/types of underlying logger have changed slightly

My personal opinion is that you shouldn't update the major version, just the minor, because currently v2.x is broken when it tries to install pino-http@v6 as peer dep.

[holm]

Thanks for fixing this. Looking forward to be abe to update pino and related libs.

I would also vote for a minor version change for the same reason as @jarcodallo

[iamolegga]

Yes, correct, will ship now, thanks, everyone!

[iamolegga]

please check out v2.4.0 🎉