feat: Add negative years support #2640
Conversation
Testing format without parameter
|
This looks good, I added a test (in manipulate.test.js): Just to make sure that adding/subtracting were working well. I tried to commit to your fork, but it didn't work. |
|
@willismonroe I added those test for you |
|
That looks good! |
|
Hi Dear @willismonroe It's now a plugin to be extended as @iamkun suggested |
test/plugin/negativeYear.test.js
Outdated
| const date3 = '01-03--2021' | ||
| const d = date.match(REGEX_PARSE) | ||
| expect(dayjs(date).format('YYYY-MM-DD')).toBe(`-${moment(date).format('YYYY-MM-DD')}`) | ||
| expect(dayjs(date).format()).toBe(`-${moment(date).format()}`) |
There was a problem hiding this comment.
could we remove moment in this test case? as far as i know, moment does not support nagative year
src/plugin/negativeYear/index.js
Outdated
| if (typeof date === 'string' && date.indexOf(`-${fullYear}`) !== -1) { | ||
| return dayjs(newDate).subtract(fullYear * 2, 'year').toDate() | ||
| } | ||
| return newDate |
There was a problem hiding this comment.
we can return the passed in the original cfg.date directly, without dealing with logic like !date
|
@iamkun Changes are done. Let me know if anything else will be great |
src/plugin/negativeYear/index.js
Outdated
| if (typeof date === 'string' && date.indexOf(`-${fullYear}`) !== -1) { | ||
| return dayjs(newDate).subtract(fullYear * 2, 'year').toDate() | ||
| } | ||
| return newDate |
There was a problem hiding this comment.
maybe we should return date not newDate, cause cfg.date is the untouched original one, just leave it to the current main parse logic
|
THX |
Add ability to parse negative years
This fix 2636 issue