New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved PolyfaceQuery.ts #6725

Merged

saeeedtorabi merged 6 commits into master from saeed-torabi/polyface-query

May 21, 2024

Contributor

saeeedtorabi commented May 13, 2024

Improved formatting and documentations of PolyfaceQuery.ts.
Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions and fixed tests accordingly.
Added md doc for polyface dihedral angles.
Improved tests.

saeeedtorabi requested review from a team, bbastings and dassaf4 as code owners

May 13, 2024 18:52

saeeedtorabi requested review from jasdom and grigasp

May 13, 2024 18:52

saeeedtorabi commented

View reviewed changes

core/geometry/src/polyface/PolyfaceQuery.ts Outdated Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/polyface/PolyfaceQuery.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/polyface/PolyfaceQuery.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/polyface/PolyfaceQuery.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/polyface/PolyfaceQuery.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/clipping/ClipUtilities.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/Polyface.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/Polyface.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/Polyface.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/Polyface.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/Polyface.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/Polyface.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/PolyfaceQuery.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/PolyfaceQuery.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/polyface/PolyfaceQuery.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/serialization/FlatBuffer.test.ts Show resolved Hide resolved

saeeedtorabi commented

View reviewed changes

core/geometry/src/test/topology/ChainCollector.test.ts Show resolved Hide resolved

saeeedtorabi force-pushed the saeed-torabi/polyface-query branch from 782b083 to e39875e Compare

May 13, 2024 21:36

dassaf4 requested changes

View reviewed changes

core/geometry/internaldocs/Polyface.md Outdated Show resolved Hide resolved

core/geometry/internaldocs/Polyface.md Outdated Show resolved Hide resolved

core/geometry/internaldocs/Polyface.md Outdated Show resolved Hide resolved

core/geometry/src/polyface/Polyface.ts Outdated Show resolved Hide resolved

core/geometry/src/polyface/IndexedPolyfaceVisitor.ts Outdated Show resolved Hide resolved

core/geometry/src/polyface/PolyfaceQuery.ts Outdated Show resolved Hide resolved

core/geometry/src/polyface/PolyfaceQuery.ts Outdated Show resolved Hide resolved

docs/changehistory/NextVersion.md Outdated Show resolved Hide resolved

docs/changehistory/NextVersion.md Outdated Show resolved Hide resolved

docs/changehistory/NextVersion.md Outdated Show resolved Hide resolved

saeeedtorabi force-pushed the saeed-torabi/polyface-query branch from e39875e to a5059d3 Compare

May 21, 2024 17:46

saeeedtorabi added 5 commits

May 21, 2024 14:20


          Improved PolyfaceQuery.ts

31e2608

- Improved formatting and documentations of PolyfaceQuery.ts.
- Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions
and fixed tests accordingly.
- Added md doc for polyface dihedral angles.
- Improved tests.


          Removed duplicate test (Polyface.RaggedBoxVolume)

2ebbd23


          Fixed lint issue

cb9c445


          Addressed PR review comments

73aa5b3


          Ran extract-api

9dafc7a

saeeedtorabi force-pushed the saeed-torabi/polyface-query branch from 0cd7135 to 9dafc7a Compare

May 21, 2024 18:20


          Address final comments

5e42441

dassaf4 approved these changes

View reviewed changes

saeeedtorabi enabled auto-merge (squash)

May 21, 2024 19:14

bbastings approved these changes

View reviewed changes

saeeedtorabi merged commit 9ab6568 into master

16 checks passed

saeeedtorabi deleted the saeed-torabi/polyface-query branch

May 21, 2024 20:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bbastings bbastings approved these changes

dassaf4 dassaf4 approved these changes

jasdom Awaiting requested review from jasdom jasdom is a code owner automatically assigned from iTwin/itwinjs-core

grigasp Awaiting requested review from grigasp grigasp is a code owner automatically assigned from iTwin/itwinjs-core