Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and API for getListOfGCS #6724

Merged
merged 12 commits into from
May 23, 2024
Merged

Add tests and API for getListOfGCS #6724

merged 12 commits into from
May 23, 2024

Conversation

EricPaquetB
Copy link
Contributor

@EricPaquetB EricPaquetB commented May 13, 2024 •
edited by pmconne

A new function (getListOfGCS) was created in imodel-native.
This PR contains tests for this function, and an API to make it available publicly in itwinjs-core.

imodel-native: iTwin/imodel-native#756

@EricPaquetB EricPaquetB requested a review from a team as a code owner May 13, 2024 18:41
@EricPaquetB EricPaquetB mentioned this pull request May 13, 2024
Merged
aruniverse
aruniverse reviewed May 14, 2024
View reviewed changes
core/backend/src/GeoCoordServices.ts Outdated Show resolved Hide resolved
core/backend/src/GeoCoordServices.ts Outdated Show resolved Hide resolved
core/backend/src/GeoCoordServices.ts Outdated Show resolved Hide resolved
@pmconne
Copy link
Member

pmconne commented May 23, 2024 •
edited

This integration test has failed twice. Seems unrelated to your changes at a glance.

1) RealityDataAccess (#integration)
     should get RealityDataSource for reality data attachment in iModel:
   AssertionError: expected undefined not to be undefined
    at Context.<anonymous> (home/vsts/work/1/s/full-stack-tests/core/src/frontend/standalone/RealityDataAccess.test.ts:252:27)

EDIT: It's failing on other branches. I'm going to bypass policies and merge this PR.

@pmconne pmconne merged commit bf0740c into master May 23, 2024
13 of 14 checks passed
@pmconne pmconne deleted the ericp/test-gcs-list branch May 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse left review comments

@AlainRobertAtBentley AlainRobertAtBentley AlainRobertAtBentley left review comments

@pmconne pmconne pmconne approved these changes

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

@wgoehrig wgoehrig Awaiting requested review from wgoehrig wgoehrig is a code owner

@markschlosseratbentley markschlosseratbentley Awaiting requested review from markschlosseratbentley markschlosseratbentley is a code owner automatically assigned from iTwin/itwinjs-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EricPaquetB @pmconne @aruniverse @AlainRobertAtBentley @imodeljs-admin