IndexedDB Tile Cache

[andremig-bentley]

Create a local cache with IndexedDB which will be used to store tiles from the mesh export service. The IndexedDBCache class is a standalone class which interfaces with IndexedDB and can be used widely. The class can store, delete, and retrieve content from an IndexedDB database, and has the option to have the content in the database expire.

If the useIndexedDBCache conditional is set true, tiles being fetched through the itwinjs-batched-models channel will first attempt to fetch their content from an IndexedDB database. If that content cannot be found or is expired, the channel will fetch the content normally and store the content for future requests.

[andremig-bentley]

@danieliborra

Updates based on your feedback. I believe the IDBStorage class should now be testable on its own, so I'm working on getting that going.

[danieliborra]

Good progress, but we're still not there 😉
As I commented below, I'd suggest branching this branch and see how it looks when removing the new channel.
It won't take you long, and then we can discuss it further, I think it is worth a try.

[andremig-bentley]

IDBTileRequestChannel has now been fully removed, IDBStorage has been renamed to IndexedDBCacheManager (copilot's suggestion). The interface IndexedDBCache has been created with a fetch function, and IndexedDBCacheManager and IndexedDBCachePassThrough implement the interface. Within IndexedDBCacheManager, all functions except for the fetch function have been made private. Within BatchedTiles.ts, the IDBTileRequestChannel has been replaced with _localCache, an instance of IndexedDBCacheManager.

[danieliborra]

IDBTileRequestChannel has now been fully removed, IDBStorage has been renamed to IndexedDBCacheManager (copilot's suggestion). The interface IndexedDBCache has been created with a fetch function, and IndexedDBCacheManager and IndexedDBCachePassThrough implement the interface. Within IndexedDBCacheManager, all functions except for the fetch function have been made private. Within BatchedTiles.ts, the IDBTileRequestChannel has been replaced with _localCache, an instance of IndexedDBCacheManager.

It looks way better! All changes are good.
In this case, co-pilot didn't do great job 😄
What about:

• IndexedDBCache => ILocalCache or ICloudContentCache or IFetchContentCache (generic name, has nothing to do with IndexDB)
• IndexedDBCacheManager => IndexedDBCache
• IndexedDBCachePassThrough => PassThroughCache

[andremig-bentley]

Updates from most recent commit:

• Fixed all async issues/issues with database functions happening out of order, etc. Confirmed now that all database functionality is working as intended (searching, retrieving, adding, deleting, all working how/when they're supposed to).
• General cleanup, changed IDBTileStorage.ts to IndexedDBCache.ts
• Moved all changes dealing with IModelTileRequestChannels to a new branch and removed them from this PR

[markschlosseratbentley]

extract-api

[andremig-bentley]

extract-api

Taken care of.

[markschlosseratbentley]

is extract-api failing again?

[andremig-bentley]

is extract-api failing again?

Yeah it is, not sure why. I re-ran it and re-committed everything applicable with my latest commit, but it doesn’t seem to be working. Looking into that this morning

[markschlosseratbentley]

is extract-api failing again?

Yeah it is, not sure why. I re-ran it and re-committed everything applicable with my latest commit, but it doesn’t seem to be working. Looking into that this morning

All good. Approving

[pmconne]

Force-merging because unrelated failing reality data integration test.