Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of imodel02 branch #6710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Get rid of imodel02 branch #6710

wants to merge 2 commits into from
+1 −1

Conversation

naveedkhan8067
Copy link
Contributor

The imodel02 branch is not used now.

@aruniverse
Copy link
Member

Do we need this pr?

@DanRod1999
Copy link
Contributor

Do we need this pr?

the behavior of the pipeline doesn't change, but it doesn't make sense to include that in the yml file anymore.

aruniverse
aruniverse requested changes May 17, 2024
View reviewed changes
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if youre going to get rid of the branch, please actually clean up all places where we still reference the branch

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse requested changes

@DanRod1999 DanRod1999 DanRod1999 approved these changes

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

@ColinKerr ColinKerr Awaiting requested review from ColinKerr ColinKerr is a code owner

@wgoehrig wgoehrig Awaiting requested review from wgoehrig wgoehrig is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naveedkhan8067 @aruniverse @DanRod1999