Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schema import error propagation #6696

Merged
merged 18 commits into from
May 29, 2024
Merged

Conversation

akshay05n
Copy link
Contributor

imodel-native: iTwin/imodel-native#749

@akshay05n akshay05n marked this pull request as ready for review May 8, 2024 10:26
@akshay05n akshay05n requested a review from a team as a code owner May 8, 2024 10:26
@akshay05n akshay05n marked this pull request as draft May 16, 2024 12:50
@akshay05n akshay05n marked this pull request as ready for review May 22, 2024 06:21
@akshay05n akshay05n changed the title Error code mapping Use updated APIs May 22, 2024
Copy link
Contributor

mergify bot commented May 24, 2024

This pull request is now in conflicts. Could you fix it @akshay05n? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@aruniverse aruniverse changed the title Use updated APIs improve schema related error messaging May 28, 2024
@pmconne pmconne changed the title improve schema related error messaging Improve schema import error propagation May 28, 2024
core/backend/src/IModelDb.ts Outdated Show resolved Hide resolved
core/backend/src/IModelDb.ts Outdated Show resolved Hide resolved
Copy link
Member

@pmconne pmconne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending @khanaffan's approval.

@pmconne
Copy link
Member

pmconne commented May 29, 2024

Integration test failure:

  1) Schema synchronization
       import schema acquire schema lock when need to transform data:
     Error: Failed to throw error with message: "exclusive lock is already held"
      at assertThrowsAsync (src/integration/SchemaSync.test.ts:108:9)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at Context.<anonymous> (src/integration/SchemaSync.test.ts:930:5)

@akshay05n
Copy link
Contributor Author

Integration test failure:

  1) Schema synchronization
       import schema acquire schema lock when need to transform data:
     Error: Failed to throw error with message: "exclusive lock is already held"
      at assertThrowsAsync (src/integration/SchemaSync.test.ts:108:9)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at Context.<anonymous> (src/integration/SchemaSync.test.ts:930:5)

This is due to the change in importSchemas and importXmlSchemas APIs. The integration test will pass again once the native changes are merged and the new @bentley/imodeljs-native package is released.

@akshay05n akshay05n enabled auto-merge (squash) May 29, 2024 15:58
@pmconne
Copy link
Member

pmconne commented May 29, 2024

@tcobbs-bentley @toddsouthenbentley @wgoehrig @aruniverse @calebmshafer your review is required.

@pmconne
Copy link
Member

pmconne commented May 29, 2024

/azp run iTwin.js

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmconne
Copy link
Member

pmconne commented May 29, 2024

/azp run iTwin.js Docs - YAML

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmconne
Copy link
Member

pmconne commented May 29, 2024

/azp run iTwin.js Integration - GitHub

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmconne
Copy link
Member

pmconne commented May 29, 2024

@DanRod1999 any theories as to why the builds did not trigger when the addon was merged?

@DanRod1999
Copy link
Contributor

I will take a closer look. But it might just be a fluke on GitHub. I've seen pipelines not trigger before, but will investigate to make sure it is not a problem in our side

@akshay05n akshay05n merged commit bf06f9c into master May 29, 2024
13 checks passed
@akshay05n akshay05n deleted the aks/improve-error-messages branch May 29, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants