-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to SchemaSync for iModel Hub Forking, Initialization, and Profile Upgrades #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
…b.com/iTwin/itwinjs-core into affanK/fix-schema-sync-for-imodel-hub
…ffanK/fix-schema-sync-for-imodel-hub
…b.com/iTwin/itwinjs-core into affanK/fix-schema-sync-for-imodel-hub
khanaffan
changed the title
Improvement to SchemaSync for iModel Hub forking/init case
Improvement to SchemaSync for iModel Hub forking/init/profile-upgrade case
May 9, 2024
…b.com/iTwin/itwinjs-core into affanK/fix-schema-sync-for-imodel-hub
pmconne
approved these changes
May 17, 2024
khanaffan
commented
May 20, 2024
…b.com/iTwin/itwinjs-core into affanK/fix-schema-sync-for-imodel-hub
…ffanK/fix-schema-sync-for-imodel-hub
khanaffan
changed the title
Improvement to SchemaSync for iModel Hub forking/init/profile-upgrade case
Enhancements to SchemaSync for iModel Hub Forking, Initialization, and Profile Upgrades
May 22, 2024
rschili
approved these changes
May 23, 2024
ColinKerr
approved these changes
May 23, 2024
imodeljs-admin
requested review from
a team,
aruniverse,
calebmshafer and
wgoehrig
as code owners
May 23, 2024 23:44
This pull request is now in conflicts. Could you fix it @khanaffan? 🙏 |
Animagne
approved these changes
May 24, 2024
aruniverse
approved these changes
May 24, 2024
This integration test is failing on every PR, I'm going to bypass policies and merge this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IModel Hub initializing & forking usecase
SyncId
now meanContainerId
which of type string (instead of BeGuid) and must be provided by caller when initializing schema sync container. Previously it was random Guid that was problem when forking iModel from specific changeset.containerId
toSyncId
and will also transfer theDataVer
from the iModel to the new container.Profile upgrades
When an iModel undergoes a profile upgrade, it is now also pushed to the schema sync container, whereas previously it was not.
IModelDb.upgradeSchemas()
function in iTwin ensures that the profile upgrade is distributed to the users.Other important changes
Changes
ChangesetType.SchemaSync
which isChangesetType.Schema | 64 = 65
.IModelDb.pullChanges()
automatically doesSchemaSync.pull()
after incoming changeset are applied.IModelDb.pushChanges()
automatically doesSchemaSync.pull()
before pushing changes.SchemaSync.pull()
. This allow application to pull new schema changes at any time.SchemaSync.setTestCache()
now store cache dir inbe_Local
. This is done to allow testing of profile/schema upgrade which require a SchemaSync container lock while iModelDb connection is in close state.SchemaSync.initializeForIModel()
ContainerId
which is use asSyncId
.overrideContainer
flag allowSchemaSync.initializeForIModel()
to override current SchemaSync container and initialize new one.namespace: ec_Db
&name: localDbInfo
) is replaced.IModelDb.doUpgrade()
.imodel-native: iTwin/imodel-native#744