Add documentation for openCheckpoint and do prefetching in IPC/desktop case #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kabentley
reviewed
Mar 26, 2024
|
The default should be to start a prefetch for IPC, but there should be a way to tell it not to do so. |
kabentley
reviewed
Apr 26, 2024
kabentley
reviewed
Apr 29, 2024
| return connection; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
there must have been a bad merge. Why did this come back?
There was a problem hiding this comment.
Sorry I was trying to git commit amend the email associated with two previous commits. Accidentally made this bad merge, now it's resolved.
jiaruiz717
force-pushed
the
jiarui/addDocumentationForOpenCheckPoint
branch
from
2508910
to
a6c56a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As https://github.com/iTwin/itwinjs-backlog/issues/1036
Add documentation for openCheckpoint and do prefetching in IPC/desktop case. Note that this is a draft PR. As discussed with @nick4598, we will do perf test to figure out what is an appropriate window size and prefetching threshold. Documentation will be adjusted accordingly and new tests will be added.