Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RC on older Maj version #6244

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

DanRod1999
Copy link
Contributor

Add new parameter called releaseCandidatePrevMaj which runs the the create branch step job.

Skips other RC tasks as I believe they are unnecessary/unwanted in this circumstance.

Once branch is created I believe we can run minor bump once the new "RC" clears all its checks

Need to figure out what steps are needed in the updateMaster job because I believe some of them are necessary but not sure about all of them.

@aruniverse
Copy link
Member

what happens if i run this pipeline with minor on a previous release/X.x branch ?

@DanRod1999
Copy link
Contributor Author

DanRod1999 commented Nov 30, 2023

what happens if i run this pipeline with minor on a previous release/X.x branch ?

  • node common/scripts/install-run-rush version --override-bump ${{ parameters.BumpType }} --version-policy prerelease-monorepo-lockStep --bump
  • # When creating a minor release, the NextVersion.md need to be cleared and the contents placed into a {Version Number}.md file
  • git tag -a release/$(getVersion.version) -m "v$(getVersion.version)"

these three steps occur when you run minor bump

  • No RC is created (don't know if thats important)
    • this also implies no 3.8.0-dev.x version are published to npm
  • release branch isn't created (this happens when we run the pipeline as releaseCandidate

just running minor on this would work if we create the release branch for the new minor manually I think, but this is just an educated guess. I don't know how:
node common/scripts/install-run-rush version --override-bump ${{ parameters.BumpType }} --version-policy prerelease-monorepo-lockStep --bump
behaves when the current version is already --version-policy prerelease-monorepo-lockStep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants