Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin ts-node. #3895

Merged
merged 1 commit into from Jul 4, 2022
Merged

Unpin ts-node. #3895

merged 1 commit into from Jul 4, 2022

Conversation

pmconne
Copy link
Member

@pmconne pmconne commented Jul 3, 2022

#3832 pinned ts-node to 10.8.0 because a bug in 10.8.1 broke nyc.
It is fixed in 10.8.2.

@pmconne pmconne requested review from a team as code owners July 3, 2022 21:33
@pmconne pmconne enabled auto-merge (squash) July 3, 2022 21:33
@pmconne
Copy link
Member Author

pmconne commented Jul 3, 2022

@grigasp @saskliutas @roluk fyi this test failed on macOS -- I will rerun to see if it's just flaky.
UPDATE: nope, failed again. I guess I'll try to figure out what the problem is.

--[ FAILURE: presentation-full-stack-tests ]-------[ 4 minutes 55.0 seconds ]--


  323 passing (2m)
  1 failing

  1) ReadWrite
       Handling read-write operations
         handles schema import during nodes request:

      AssertionError: expected +0 to equal 85
      + expected - actual

      -0
      +85
      
      at Context.<anonymous> (src/backend/ReadWrite.test.ts:77:31)

@grigasp
Copy link
Member

grigasp commented Jul 4, 2022

@grigasp @saskliutas @roluk fyi this test failed on macOS -- I will rerun to see if it's just flaky. UPDATE: nope, failed again. I guess I'll try to figure out what the problem is.

--[ FAILURE: presentation-full-stack-tests ]-------[ 4 minutes 55.0 seconds ]--


  323 passing (2m)
  1 failing

  1) ReadWrite
       Handling read-write operations
         handles schema import during nodes request:

      AssertionError: expected +0 to equal 85
      + expected - actual

      -0
      +85
      
      at Context.<anonymous> (src/backend/ReadWrite.test.ts:77:31)

We're tracking the issue with https://github.com/iTwin/itwinjs-backlog/issues/247. @saskliutas already has a fix.

@pmconne pmconne disabled auto-merge July 4, 2022 13:00
@pmconne pmconne merged commit 6e58a72 into master Jul 4, 2022
@pmconne pmconne deleted the pmc/unpin-ts-node branch July 4, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants