Drop deprecated ldclient-js package (#1033)

* Drop deprecated ldclient-js package
iTwin · Mar 25, 2021 · 4dc481f · 4dc481f
1 parent 5798d80
commit 4dc481f
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 98 deletions.
diff --git a/common/api/imodeljs-frontend.api.md b/common/api/imodeljs-frontend.api.md
@@ -146,8 +146,6 @@ import { IpcAppChannel } from '@bentley/imodeljs-common';
 import { IpcAppFunctions } from '@bentley/imodeljs-common';
 import { IpcListener } from '@bentley/imodeljs-common';
 import { IpcSocketFrontend } from '@bentley/imodeljs-common';
-import { LDClient } from 'ldclient-js';
-import { LDFlagValue } from 'ldclient-js';
 import { LightSettings } from '@bentley/imodeljs-common';
 import { LinePixels } from '@bentley/imodeljs-common';
 import { LocalBriefcaseProps } from '@bentley/imodeljs-common';
@@ -3388,7 +3386,6 @@ export interface FrameRenderData {
 export enum FrontendLoggerCategory {
     Authorization = "imodeljs-frontend.Authorization",
     EventSource = "imodeljs-frontend.EventSource",
-    FeatureToggle = "imodeljs-frontend.FeatureToggles",
     // @alpha
     FeatureTracking = "imodeljs-frontend.FeatureTracking",
     FrontendRequestContext = "imodeljs-frontend.FrontendRequestContext",
@@ -4322,8 +4319,6 @@ export class IModelApp {
     static createRenderSys(opts?: RenderSystem.Options): RenderSystem;
     // @beta
     static get extensionAdmin(): ExtensionAdmin;
-    // @internal
-    static get featureToggles(): FeatureToggleClient;
     // @alpha
     static formatElementToolTip(msg: string[]): HTMLElement;
     // @internal (undocumented)
@@ -4402,8 +4397,6 @@ export interface IModelAppOptions {
     authorizationClient?: FrontendAuthorizationClient;
     // @beta
     extensionAdmin?: ExtensionAdmin;
-    // @internal
-    featureToggles?: FeatureToggleClient;
     i18n?: I18N | I18NOptions;
     imodelClient?: IModelClient;
     // @internal (undocumented)

diff --git a/common/changes/@bentley/imodeljs-frontend/remove-deprecated-ldclient_2021-03-25-03-12.json b/common/changes/@bentley/imodeljs-frontend/remove-deprecated-ldclient_2021-03-25-03-12.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@bentley/imodeljs-frontend",
+      "comment": "Drop deprecated ldclient-js dependency",
+      "type": "none"
+    }
+  ],
+  "packageName": "@bentley/imodeljs-frontend",
+  "email": "31107829+calebmshafer@users.noreply.github.com"
+}
diff --git a/core/frontend/package.json b/core/frontend/package.json
@@ -105,7 +105,6 @@
     "@bentley/usage-logging-client": "2.15.0-dev.7",
     "fuse.js": "^3.3.0",
     "js-base64": "^2.4.5",
-    "ldclient-js": "^2.6.0",
     "oidc-client": "^1.9.1",
     "semver": "^5.5.0",
     "xml-js": "~1.6.11",
@@ -120,4 +119,4 @@
     ],
     "extends": "plugin:@bentley/imodeljs-recommended"
   }
-}
+}
diff --git a/core/frontend/src/FeatureToggleClient.ts b/core/frontend/src/FeatureToggleClient.ts
diff --git a/core/frontend/src/FrontendLoggerCategory.ts b/core/frontend/src/FrontendLoggerCategory.ts
@@ -32,9 +32,6 @@ export enum FrontendLoggerCategory {
   /** The logger category used for NativeApp */
   NativeApp = "imodeljs-frontend.NativeApp",
 
-  /** The logger category used by feature-flag-related functions */
-  FeatureToggle = "imodeljs-frontend.FeatureToggles",
-
   /**
    * The logger category used by FeatureTrackingManager
    * @alpha

diff --git a/core/frontend/src/IModelApp.ts b/core/frontend/src/IModelApp.ts
@@ -30,7 +30,6 @@ import * as drawingViewState from "./DrawingViewState";
 import { ElementLocateManager } from "./ElementLocateManager";
 import { EntityState } from "./EntityState";
 import { ExtensionAdmin } from "./extension/ExtensionAdmin";
-import { FeatureToggleClient } from "./FeatureToggleClient";
 import { FrontendLoggerCategory } from "./FrontendLoggerCategory";
 import { FrontendRequestContext } from "./FrontendRequestContext";
 import * as modelselector from "./ModelSelectorState";
@@ -129,10 +128,6 @@ export interface IModelAppOptions {
   extensionAdmin?: ExtensionAdmin;
   /** If present, supplies the [[UiAdmin]] for this session. */
   uiAdmin?: UiAdmin;
-  /** if present, supplies the [[FeatureToggleClient]] for this session
-   * @internal
-   */
-  featureToggles?: FeatureToggleClient;
   rpcInterfaces?: RpcInterfaceDefinition[];
 }
 
@@ -199,7 +194,6 @@ export class IModelApp {
   private static _animationRequested = false;
   private static _animationInterval: BeDuration | undefined = BeDuration.fromSeconds(1);
   private static _animationIntervalId?: number;
-  private static _featureToggles: FeatureToggleClient;
   private static _securityOptions: FrontendSecurityOptions;
   private static _mapLayerFormatRegistry: MapLayerFormatRegistry;
 
@@ -270,11 +264,6 @@ export class IModelApp {
    */
   public static readonly telemetry: TelemetryManager = new TelemetryManager();
 
-  /** The [[FeatureToggleClient]] for this session
-   * @internal
-   */
-  public static get featureToggles() { return this._featureToggles; }
-
   /** Map of classFullName to EntityState class */
   private static _entityClasses = new Map<string, typeof EntityState>();
 
@@ -424,7 +413,6 @@ export class IModelApp {
     this._extensionAdmin = (opts.extensionAdmin !== undefined) ? opts.extensionAdmin : new ExtensionAdmin({});
     this._quantityFormatter = (opts.quantityFormatter !== undefined) ? opts.quantityFormatter : new QuantityFormatter();
     this._uiAdmin = (opts.uiAdmin !== undefined) ? opts.uiAdmin : new UiAdmin();
-    this._featureToggles = (opts.featureToggles !== undefined) ? opts.featureToggles : new FeatureToggleClient();
     this._mapLayerFormatRegistry = new MapLayerFormatRegistry(opts.mapLayerOptions);
 
     [