Pin axios to 1.2.2 (#202)

* Pin axios version * Add a null check and log error * Pin to exact 1.1.0 * Pin to 1.2.2 * Revert null change
iTwin · Sep 14, 2023 · d957211 · d957211
1 parent 42e9d92
commit d957211
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 15 deletions.
diff --git a/clients/imodels-client-management/package.json b/clients/imodels-client-management/package.json
@@ -33,7 +33,7 @@
     "extends": "./node_modules/@itwin/imodels-client-common-config/.eslintrc.json"
   },
   "dependencies": {
-    "axios": "^1.0.0"
+    "axios": "1.2.2"
   },
   "devDependencies": {
     "@itwin/imodels-client-common-config": "workspace:*",

diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/itwin-platform-access/imodels-access-backend/package.json b/itwin-platform-access/imodels-access-backend/package.json
@@ -34,7 +34,7 @@
     "@azure/abort-controller": "^1.1.0",
     "@itwin/imodels-access-common": "workspace:*",
     "@itwin/imodels-client-authoring": "workspace:*",
-    "axios": "^1.0.0"
+    "axios": "1.2.2"
   },
   "devDependencies": {
     "@itwin/core-backend": "^4.0.0",

diff --git a/itwin-platform-access/imodels-access-backend/src/CheckpointHelperFunctions.ts b/itwin-platform-access/imodels-access-backend/src/CheckpointHelperFunctions.ts
@@ -7,6 +7,7 @@ import {
   CheckpointArg, CheckpointProps,
   V2CheckpointAccessProps
 } from "@itwin/core-backend";
+import { Logger } from "@itwin/core-bentley";
 import { Constants } from "@itwin/imodels-access-common/lib/Constants";
 import { handleAPIErrors } from "@itwin/imodels-access-common/lib/ErrorHandlingFunctions";
 import axios, { AxiosResponse } from "axios";
@@ -79,7 +80,12 @@ export async function getV1CheckpointSize(downloadUrl: string): Promise<number>
   const contentRangeHeaderName = "content-range";
 
   const response: AxiosResponse = await axios.get(downloadUrl, { headers: { Range: emptyRangeHeaderValue } });
-  const rangeHeaderValue: string = response.headers[contentRangeHeaderName];
+  const rangeHeaderValue: string | undefined = response.headers[contentRangeHeaderName];
+  if (!rangeHeaderValue) {
+    Logger.logError("BackendIModelsAccess", "Cannot determine total V1 checkpoint size");
+    return 0;
+  }
+
   const rangeTotalBytesString: string = rangeHeaderValue.split("/")[1];
   const rangeTotalBytes: number = parseInt(rangeTotalBytesString, 10);
 

diff --git a/tests/imodels-clients-tests/package.json b/tests/imodels-clients-tests/package.json
@@ -42,7 +42,7 @@
     "@itwin/imodels-client-test-utils": "workspace:*",
     "@itwin/object-storage-azure": "^2.0.0",
     "@itwin/object-storage-core": "^2.0.0",
-    "axios": "^1.0.0",
+    "axios": "1.2.2",
     "chai": "~4.3.4",
     "chai-as-promised": "~7.1.1",
     "dotenv": "~10.0.0",

diff --git a/utils/imodels-client-test-utils/package.json b/utils/imodels-client-test-utils/package.json
@@ -33,7 +33,7 @@
     "@itwin/imodels-client-authoring": "workspace:*",
     "@itwin/imodels-client-management": "workspace:*",
     "@itwin/object-storage-core": "^2.0.0",
-    "axios": "^1.0.0",
+    "axios": "1.2.2",
     "chai": "~4.3.4",
     "dotenv": "~10.0.0",
     "inversify": "~6.0.1",