This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
chore: Fix prettier inconsistencies from duplicate versions #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
a team,
veekeys and
elephantcatdog
and removed request for
a team
5 tasks
veekeys
reviewed
May 3, 2022
veekeys
approved these changes
May 3, 2022
mayank99
added a commit
to iTwin/iTwinUI
that referenced
this pull request
Dec 21, 2022
…winUI-react#651) deduped the prettier versions in our lockfile to avoid conflicts, and ran yarn prettier against the repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #613, we had two different versions of
prettierin the lockfile. One of them was being used for IDE save andprettier --write, and a different one was being used forlint-staged. This led to random unintended formatting changes like in #636 (comment) and #648 (comment).So I deduped the prettier versions in our lockfile and ran
yarn prettieragainst the repo and also verified thatlint-stageddoesn't break anything on committing. The only resulting formatting change is inComboBox.tsx, reverting the unintended one from #636.