This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Convert to monorepo #613
chore: Convert to monorepo #613
Changes from 1 commit
5f73759
a483695
b54e98a
0e5631b
e6db666
f1c4901
c976537
aad0c98
0a768df
ee5dc5b
8de8b26
724299d
042926e
6693de4
4ca5ca5
3ea4d4f
257efe9
363d5e0
23ef614
f4175ee
b0a62ad
1cdc02f
e85bb71
871507a
e4763db
213c2d5
58c2f19
07ef30a
60ce4f1
4639a7b
dcc01f4
23d82d5
457bcda
2e6979f
94d170e
112ecd1
be2eee7
d3a1212
28cbabf
80daaea
0523924
b6c1f5f
0b92fe3
13c0c35
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had this before too
plugin:prettier/recommended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here this
"prettier/prettier": [ 1 ],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previuosly we were copying license and changelog files too. Will those be included ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like changelog might need to be manually added
https://docs.npmjs.com/cli/v8/configuring-npm/package-json#files
edit: looks like those get included automatically 👍
https://docs.npmjs.com/cli/v8/using-npm/developers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok turns out they were not included.
Fixed in
0b92fe3
and tested usingnpm pack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this path correct? it shows error to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is correct.
configs
is the name of the package where I've moved this file.Screen.Recording.2022-04-21.at.9.59.13.AM.mov