forked from angular/angular
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(platform-browser): update started state on reset (angular#41608)
This commit fixes the state of variable _started on call of reset method. Earlier behaviour was on call of `reset()` method we are not setting back `_started` flag's value to false and it created various issue for end user which were expecting this behaviour as per name of method. We provided end user `reset()` method, but it was empty method and on call of it wasn't doing anything. As end user/developer were not able to reuse animation not animation after call of reset method. In this PR on call of `reset()` method we are setting flag `_started` value to false which can be accessed by `hasStarted()`. Resolves angular#18140 PR Close angular#41608
- Loading branch information
1 parent
a5044dc
commit a2a9c14
Showing
6 changed files
with
50 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters