Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotee's name will now be added to the quote. #4399

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kuchikuu
Copy link

@kuchikuu kuchikuu commented Nov 3, 2022

Quotee's name will be appended to the message when quoted. Changes:
Line 53 - variable that holds quotee's name
Line 67 - variable quotee is appended to the beginning of the body string, then a string " wrote:\n" is added for a nice visual effect.

Line 65 - Because of the change, if someone uses /me then the quote looks "simple".
To me, a /me is like reaction. (/me pukes, /me smiles) - it should be "distinguished" from other quotes, thus I made the whole "/me" quote bald to "pop up"


Hello.
I am aware of the following pull request:
#4091

But in my case, I'm modifying "MessageUtils.java" to easily add the name from Message object.
The change is very simple.
In function prepareQuote() I used UIHelper.getMessageDisplayName() in order to assign the name to a variable.
Then, I simply appended the variable to the general quote body.

Because of this, I also modified how /me quotes are handled.
Basically, I made them bold to "stand out".
If name-appending is a good pull request but /me "bolding" is not, then I can make a new pull request without the /me change.


This is bare bones. No toggle.
I've seen that SmsS4 created a nice toggle in the menu.
I can add that too if needed.

I just think, such name "appending" should be a default.
I was getting tired of manually adding the names, because I mostly talk in MUCs.


On a second thought, perhaps I should have used message.getAvatarName()
because UIHelper.getMessageDisplayName() is a return of .getAvatarName()

This can be fixed if needed.


Screenshot:

example

Quotee's name will be appended to the message when quoted.
Changes:
 Line 53 - variable that holds quotee's name
 Line 67 - variable quotee is appended to the beginning of the body string, then a string " wrote:\n" is added for a nice visual effect.

 Line 65 - Because of the change, if someone uses /me then the quote looks "simple". 
  To me, a /me is like reaction. (/me pukes, /me smiles) - it should be "distinguished" from other quotes, thus I made the whole "/me" quote bold to "pop up"
@licaon-kter
Copy link

As the other PR pretty please make it

*nickname*:
> quote

...so it looks like you'd quote manually :D

@kuchikuu
Copy link
Author

kuchikuu commented Nov 3, 2022

As the other PR pretty please make it

*nickname*:
> quote

...so it looks like you'd quote manually :D

Hello.
That's a joke or...?
I would assume that it looks better if the name is also in the "quote block".

Example from telegram:
exmaple_telegram

Or do you mean that the "wrote:" part should be omitted in order to just have:

nick
Some text

?

The thing is that you can see the asteriks surrounding the name in order to make it bold. I'm not sure if that's "pretty".

@licaon-kter
Copy link

licaon-kter commented Nov 3, 2022

Joke? Wat?

"wrote" will look odd in a multilanguage group, yes, drop it.

Bold helps.

Asteriks visible are the app devs choice given the XEP, I've long advocated for them to not show but alas.

I don't like the nick in quote, no matter if some closed silo does it.

@kuchikuu
Copy link
Author

kuchikuu commented Nov 3, 2022

"wrote" will look odd in a multilanguage group, yes, drop it.

Well, that's true.
And without a toggle, it will always be there. So I guess Pull Request will be denied :P

To be honest, I haven't seen an option to change language, so I went with an assumption that if I add "wrote" in English, it will be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants