Quotee's name will now be added to the quote. #4399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotee's name will be appended to the message when quoted. Changes:
Line 53 - variable that holds quotee's name
Line 67 - variable quotee is appended to the beginning of the body string, then a string " wrote:\n" is added for a nice visual effect.
Line 65 - Because of the change, if someone uses /me then the quote looks "simple".
To me, a /me is like reaction. (/me pukes, /me smiles) - it should be "distinguished" from other quotes, thus I made the whole "/me" quote bald to "pop up"
Hello.
I am aware of the following pull request:
#4091
But in my case, I'm modifying "MessageUtils.java" to easily add the name from Message object.
The change is very simple.
In function prepareQuote() I used UIHelper.getMessageDisplayName() in order to assign the name to a variable.
Then, I simply appended the variable to the general quote body.
Because of this, I also modified how /me quotes are handled.
Basically, I made them bold to "stand out".
If name-appending is a good pull request but /me "bolding" is not, then I can make a new pull request without the /me change.
This is bare bones. No toggle.
I've seen that SmsS4 created a nice toggle in the menu.
I can add that too if needed.
I just think, such name "appending" should be a default.
I was getting tired of manually adding the names, because I mostly talk in MUCs.
On a second thought, perhaps I should have used message.getAvatarName()
because UIHelper.getMessageDisplayName() is a return of .getAvatarName()
This can be fixed if needed.
Screenshot: