Preserve Text Nodes in XML #4359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singpolyma
force-pushed
the
xml-text-nodes
branch
from
50a5fb6
to
a5fd9ad
Compare
The XML model that was being used was not able to represent elements with text nodes and element children interspersed (such as in "markup like" XML: <x>abc <y>def</y> ghi</x>). This switches from a single content String to a list of child Node. Content is pulled from all children recursively. A list of Element children is also maintained since this list is frequently traversed so it saves runtime checks in all of those loops at the expense of a small amount of memory. Since the children and childNode lists must be kept in sync, they are both made private to avoid a child class trying to mutate one of them without a safe helper.
singpolyma
force-pushed
the
xml-text-nodes
branch
from
a5fd9ad
to
edeaa8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML model that was being used was not able to represent elements with text
nodes and element children interspersed (such as in "markup like" XML:
<x>abc <y>def</y> ghi</x>). This switches from a single content String to alist of child Node. Content is pulled from all children recursively. A list of
Element children is also maintained since this list is frequently traversed so
it saves runtime checks in all of those loops at the expense of a small amount
of memory. Since the children and childNode lists must be kept in sync, they
are both made private to avoid a child class trying to mutate one of them
without a safe helper.