Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show time for calls #3930 #4095

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show time for calls #3930 #4095

wants to merge 2 commits into from

Conversation

SmsS4
Copy link

@SmsS4 SmsS4 commented May 16, 2021

issue #3930
Hi. I added timestamp for calls and here is the result
Screenshot from 2021-05-16 22-44-12

Note: third Income call doesn't have duration but it's not a bug.
I don't know why this happens but Conversation handle incoming call string like this:

if (received) {
                if (duration > 0) {
                    viewHolder.status_message.setText(activity.getString(R.string.incoming_call_duration_timestamp, TimeFrameUtils.resolve(activity, duration), callTime));
                } else if (rtpSessionStatus.successful) {
                    viewHolder.status_message.setText(activity.getString(R.string.incoming_call_timestamp, callTime));
                } else {
                    viewHolder.status_message.setText(activity.getString(R.string.missed_call_timestamp, callTime));
                }
            } 

And in second case we have an incoming call without a duration.
Also i didn't add other languages because i didn't know does this feature accept by developers or not.
btw i'm new to android and solving issues and i didn't know should i make a PR or just comment on issue.
so sorry if i shouldn't do this :)

Sorry for my bad English.

@sonicnkt
Copy link

sonicnkt commented Sep 6, 2021

Just wanted to comment that i would love to have this added to conversations.
I never realized this wasnt there allready until i had the typical siuation of call me again in 30 minutes and continued with other stuff. Then i went back to app an realized call time (and duration) wasnt logged there at all :)

@marmistrz marmistrz mentioned this pull request Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants