Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sentry #2040

Merged
merged 2 commits into from Oct 20, 2023
Merged

Upgrade sentry #2040

merged 2 commits into from Oct 20, 2023

Conversation

federicobadini
Copy link
Contributor

@federicobadini federicobadini commented Oct 19, 2023

Upgrade to v 7.74.0.

This PR removes @sentry/tracing since it is deprecated and it is not necessary anymore.

With 7.46.0 you no longer require the @sentry/tracing package to use tracing and performance monitoring with the Sentry JavaScript SDKs. The @sentry/tracing package will be removed in a future major release, but can still be used in the meantime.

A bundle size increase that was advertised in 7.73.0. So if any increase is shown this might be the case.

We are upgrading also because version of Sentry have been associated to errors like the one we are tracking in #1808 - see here. In those case they were build errors, in ours we have runtime errors but the similarity and the fact that the fix was deployed in a newer version wrt the one we are using is worth the try.

QA

  1. Visit Vercel preview
  2. Verify that the website is working as before

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 5:35pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 5:35pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 330.92 KB (🟢 -12.22 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Upgrade to v 7.74.0.
Expect a bundle size increase that was advertised in 7.73.0.
Remove sentry tracing since it was deprecated and it is not necessary anymore
@jordycosta
Copy link
Member

dev_block 🟥 on merge conflicts

Otherwise, the site seems to be working as before 👍

@jordycosta jordycosta removed the QAing Under QA team review label Oct 19, 2023
@federicobadini
Copy link
Contributor Author

Conflict resolved
un_dev_block 👍

@deltuh-vee deltuh-vee self-assigned this Oct 20, 2023
@deltuh-vee deltuh-vee added QAing Under QA team review and removed QAing Under QA team review labels Oct 20, 2023
@deltuh-vee
Copy link
Contributor

Carry Over QA 🎬

Copy link
Member

@danielbeardsley danielbeardsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@danielbeardsley danielbeardsley merged commit 6f155b0 into main Oct 20, 2023
14 checks passed
@danielbeardsley danielbeardsley deleted the upgrade-sentry branch October 20, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants