types(Trans): add typechecking on context prop
#1732
Conversation
|
@stefan-schweiger can you review this and check if it's ok for you? |
|
Already did a short look when I saw the PR and from my side every thing seems in order |
|
ok, will merge and release in the next hour(s) |
|
thank you both... it's included in v14.1.0 |
| KPrefix = undefined, | ||
| TContext extends string | undefined = undefined, | ||
| TOpt extends TOptions & { context?: TContext } = { context: TContext }, |
There was a problem hiding this comment.
I know this was closed, but if we remove the { context: TContext } it works much better, like:
TOpt extends TOptions & { context?: TContext } in this way the IDE TS autocomplete works:
without context assignation:
with context assignation:
There was a problem hiding this comment.
Does it still correctly handle the typings for the context property of the Trans component?
There was a problem hiding this comment.
not exactly what I meant :D I meant more something like this:
fixes #1730.
This is technically a breaking change since it change
TransandTransPropstype parameters, however I don't think usually people explicit them when using the component... but who knows 🤷.I tried to replicate a type parameter structure similar to the
TFunction,however, looks like that using a single
TOpttype parameter doesn't pass the property values (likecontext) down toTransPropsproperly soParseKeysis not aware of the context value.The only alternative is to add a new type parameter and pass it down the chain, which is basically what @stefan-schweiger proposed in the above linked issue (Thanks 🙏).
Checklist
npm run test