Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit children prop to I18nextProviderProps #1478

Merged
merged 1 commit into from Apr 10, 2022
Merged

Add explicit children prop to I18nextProviderProps #1478

merged 1 commit into from Apr 10, 2022

Conversation

sachinahya
Copy link
Contributor

Fixes #1477 by explicitly specifying children prop on I18nextProviderProps.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

@adrai adrai requested a review from pedrodurek April 9, 2022 11:35
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.078% when pulling dd29120 on sachinahya:add-explicit-children into 41ff4be on i18next:master.

pedrodurek
pedrodurek approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@pedrodurek pedrodurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@adrai adrai merged commit 76ac82c into i18next:master Apr 10, 2022
@adrai
Copy link
Member

adrai commented Apr 10, 2022 •
edited

should be included in v11.16.3

@sachinahya sachinahya deleted the add-explicit-children branch April 10, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrodurek pedrodurek pedrodurek approved these changes

Assignees

@pedrodurek pedrodurek

Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property 'children' does not exist on type 'IntrinsicAttributes & I18nextProviderProps' on React 18 types
4 participants
@sachinahya @coveralls @adrai @pedrodurek