more html entities to unescape by default (#1538)

i18next · Jul 27, 2022 · f91903b · f91903b
1 parent 85857b2
commit f91903b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/src/unescape.js b/src/unescape.js
@@ -1,4 +1,6 @@
-const matchHtmlEntity = /&(?:amp|#38|lt|#60|gt|#62|apos|#39|quot|#34);/g;
+// unescape common html entities
+
+const matchHtmlEntity = /&(?:amp|#38|lt|#60|gt|#62|apos|#39|quot|#34|nbsp|#160|copy|#169|reg|#174|hellip|#8230);/g;
 
 const htmlEntities = {
   '&amp;': '&',
@@ -11,6 +13,14 @@ const htmlEntities = {
   '&#39;': "'",
   '&quot;': '"',
   '&#34;': '"',
+  '&nbsp;': ' ',
+  '&#160;': ' ',
+  '&copy;': '©',
+  '&#169;': '©',
+  '&reg;': '®',
+  '&#174;': '®',
+  '&hellip;': '…',
+  '&#8230;': '…',
 };
 
 const unescapeHtmlEntity = (m) => htmlEntities[m];

diff --git a/test/trans.render.spec.js b/test/trans.render.spec.js
@@ -636,7 +636,7 @@ describe('trans should allow escaped html', () => {
         <a
           href="/msgs"
         >
-          &lt;&nbsp;&&gt;
+          &lt; &&gt;
         </a>
         .
       </div>

diff --git a/test/unescape.spec.js b/test/unescape.spec.js
@@ -0,0 +1,11 @@
+import { unescape } from '../src/unescape';
+
+describe('unescape', () => {
+  it('should correctly unescape', () => {
+    const unescaped = unescape(
+      '&amp; &#38; &lt; &#60; &gt; &#62; &apos; &#39; &quot; &#34; &nbsp; &#160; &copy; &#169; &reg; &#174; &hellip; &#8230;',
+    );
+
+    expect(unescaped).toEqual('& & < < > > \' \' " "     © © ® ® … …');
+  });
+});