Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prepare v13 #2018

Merged
merged 9 commits into from
Nov 14, 2022
Merged

docs: prepare v13 #2018

merged 9 commits into from
Nov 14, 2022

Conversation

belgattitude
Copy link
Contributor

@belgattitude belgattitude commented Nov 10, 2022

Prepare v13, last checks and release notes

@belgattitude
Copy link
Contributor Author

belgattitude commented Nov 10, 2022

Might be blocked in belgattitude/nextjs-monorepo-example#2864

image

I tried without peers thinking it was about that, then locked the babel versions to build,... Needs to track it down cause I feel there's a change that happened somewhere else

Will look this week-end or Monday

@@ -1,5 +1,50 @@
## Troubleshoot

### Can't find next-i18next.config.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrai that's a proposal

The goal is to help users:

  • monorepos and pnpm users (pnpm creates symlinks)

I'm not totally for this solution. I would prefer to make the config required, see also #2013. But that would be another BC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #1917 (comment)

@belgattitude
Copy link
Contributor Author

belgattitude commented Nov 14, 2022

@adrai I'll plan to merge this afternoon. For me the release v13 can be done. There's just an upstream issue regarding i18next speed in i18next/i18next#1857.

Not sure if we want to wait for it or not

@adrai
Copy link
Member

adrai commented Nov 14, 2022

@pedrodurek what is your opinion?

@belgattitude
Copy link
Contributor Author

I'll merge as it's only doc and some peer-deps update.

But interested about @pedrodurek opinion as well. I'll see if I can advance on other topics.

Thanks a lot @adrai

@belgattitude belgattitude merged commit 260fd2c into master Nov 14, 2022
@belgattitude belgattitude deleted the prepare-release-v13 branch November 14, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants