Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bundlesize in favour of size-limit #2008

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

belgattitude
Copy link
Contributor

@belgattitude belgattitude commented Nov 7, 2022

I'd like to remove bundlesize. Why ?

  • We introduced size-limit (and npm run check-size in the QA improve checks #1969 and subsequent PR's). I feel it's an easier tool.
  • Bundlesize is relying on itorb (node-gyp), this makes install slower as it has to be compiled for no so much benefits (minus 15 seconds in install).
  • I also separate check-size from test-e2e. (I feel it's clearer IMO, but open any changes here)
npm why iltorb
iltorb@2.4.5 extraneous
node_modules/iltorb
  iltorb@"^2.4.3" from brotli-size@0.1.0
  node_modules/brotli-size
    brotli-size@"0.1.0" from bundlesize@0.18.1
    node_modules/bundlesize

@belgattitude belgattitude marked this pull request as ready for review November 7, 2022 14:19
@belgattitude
Copy link
Contributor Author

@adrai let me know your opinion on this.

@adrai
Copy link
Member

adrai commented Nov 7, 2022

@adrai let me know your opinion on this.

ok for me... you're the expert here ;-)

@belgattitude belgattitude merged commit f568823 into i18next:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants