Drop node 12 support (next major) #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be released together with the new i18next and react-i18next major versions 👍 |
|
fyi: i18next/i18next#1852 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to bump the minimum node version to 14.x (12.x is not maintained).
I feel it might avoid issue if this PR is merged: #1973
Version
Next major version (13).
Makes sense to merge along #1966 as both will bump a major.
Note
I've been pretty lax on version (<14). In practice, I would recommended 14.13.1 minimum. But it's fine to not enforce it. (this helps when moving to pure esm)