Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(size-limit): check also for next-app dist folder #1972

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

belgattitude
Copy link
Contributor

I know we already have bundlesize, but I'd like to expand the size-checks to the example app with size-limit. I'd like to have fine grain control on side-effects of publish improvements.

Same method used as in #1969

Running

npm run check-size

Will give

image

@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
core-js-pure@3.25.5 (added) postinstall package.json via @types/testing-library__cypress@5.0.9, @testing-library/dom@7.31.2, aria-query@4.2.2, @babel/runtime-corejs3@7.19.6,examples/ssg/package.json via eslint-config-next@12.3.1, eslint-plugin-jsx-a11y@6.6.1, aria-query@4.2.2, @babel/runtime-corejs3@7.19.6
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bin Script Confusion ✅ no new bin script confusions
Bin script shell injection ✅ no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore core-js-pure@3.25.5

Powered by socket.dev

@adrai adrai merged commit 55a285b into i18next:master Oct 20, 2022
@belgattitude
Copy link
Contributor Author

A a later point we can instruct the CI to publish a comment about sizes. But not right now

@belgattitude
Copy link
Contributor Author

@adrai Don't work late :)

@adrai
Copy link
Member

adrai commented Oct 20, 2022

merged via my smartphone ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants