Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: remove const from ParseKeys Context type parameter and disable skipLibCheck #2169

Merged
merged 2 commits into from Apr 9, 2024

Conversation

marcalexiei
Copy link
Member

Fixes #2168

  • Remove const Context type parameter of ParseKeys type
  • Update typescript to 5.4.4
  • to prevent silent error on *.d.ts that won't be catched by ts tests,
    tsconfig.json compilerOptions.skipLibCheck has been changed to false.
  • Update tsconfig.json module and moduleResolution using "modern" values.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/typescript@5.4.4 None 0 32.4 MB typescript-bot

🚮 Removed packages: npm/typescript@5.1.3

View full report↗︎

@coveralls
Copy link

Coverage Status

coverage: 96.197%. remained the same
when pulling 6a3f843 on marcalexiei:const-fix-and-lib-check-enable
into e8efbf0 on i18next:master.

@marcalexiei marcalexiei marked this pull request as ready for review April 9, 2024 17:15
@marcalexiei marcalexiei changed the title types: types: remove const from ParseKeys Context type parameter and disable skipLibCheck types: remove const from ParseKeys Context type parameter and disable skipLibCheck Apr 9, 2024
@adrai adrai merged commit 2c8d493 into i18next:master Apr 9, 2024
9 checks passed
@adrai
Copy link
Member

adrai commented Apr 9, 2024

thank you 🙏
included in v23.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ‘const’ keyword is extraneous in the ParseKeys type definition.
3 participants