Output the files in which a string is found in customValueTemplate #970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
Thanks again for the great framework and maintenance @karellm -- we've now translated our Wanderlog trip planner mobile app to French with help from this!
As a part of the process, we realized that sometimes, translators can benefit with some extra context about the strings they're translating: e.g., it matters if a string like "Round trip" comes from a file called FlightSearchInput.tsx. The
customValueTemplates
have been really helpful with other annotations, so we thought it'd be helpful to extend it so that we can put:Changes
defaultValue
) which will also substitute in the paths of all the files where we found a particular keyNote: to make this easier to merge, I also invited you to have write access to our repository.
Example output when run on our codebase:
Does it fix an existing ticket?
No
Checklist
yarn test
(see details here)