Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #919

Merged
merged 2 commits into from Oct 1, 2023
Merged

Update index.d.ts #919

merged 2 commits into from Oct 1, 2023

Conversation

Cielquan
Copy link
Contributor

Why am I submitting this PR

I removed two config values from the UserConfig type which were removed back in v7.0.
I also updated the defaultValue function type to include the 'value' argument which was missing.

Does it fix an existing ticket?

No

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@karellm karellm merged commit 55e074c into i18next:master Oct 1, 2023
4 checks passed
@karellm
Copy link
Member

karellm commented Oct 1, 2023

Thanks, this is in 8.8.0

@Cielquan
Copy link
Contributor Author

Cielquan commented Oct 2, 2023

Thanks for merge and fast release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants