fix: search file path when no --config option #692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karellm
reviewed
Nov 14, 2022
| result = await configReader.load(program.opts().config) | ||
| } else { | ||
| result = await configReader.search() | ||
| } | ||
| config = result.config |
There was a problem hiding this comment.
This is still possibly problematic as if there is no config file this will fail (result.config is then undefined). I've pushed a fix as 7.0.2
| @@ -117,16 +123,19 @@ import i18nTransform from '../dist/transform.js' | |||
| } | |||
| } | |||
|
|
|||
| let basePath = process.cwd() | |||
There was a problem hiding this comment.
Could you make a PR with only that part of the code? I've missed that in my fix.
|
It is published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
Fix my previous PR #673 which removed default value for
--configoption but didn't search for config files with lilconfig correctly.Does it fix an existing ticket?
No
Checklist
yarn test(see details here)