Make defaultValue take precedence over useKeysAsDefaultValue if present

[JonathanSun]

Why am I submitting this PR

When useKeysAsDefaultValue=true, only apply the replacement if no defaultValue is specified.

Does it fix an existing ticket?

Yes #671

Checklist

• only relevant code is changed (make a diff before you submit the PR)
• tests are included and pass: yarn test (see details here)
• documentation is changed or added

[karellm]

@JonathanSun This is a breaking change so I'm very reluctant to add this to the project as it will introduce an unexpected behaviour for current users.

That said I think what you want to do make total sense. I believe a much better solution is to rely on the defaultValue option and pass it a function. The only argument missing to do what you want is the extracted default value.

I believe we could remove skipDefaultValues and useKeysAsDefaultValue altogether and simplify the API while at it!

What do you think?

[JonathanSun]

@JonathanSun This is a breaking change so I'm very reluctant to add this to the project as it will introduce an unexpected behaviour for current users.

That said I think what you want to do make total sense. I believe a much better solution is to rely on the defaultValue option and pass it a function. The only argument missing to do what you want is the extracted default value.

I believe we could remove skipDefaultValues and useKeysAsDefaultValue altogether and simplify the API while at it!

What do you think?

Sure. See #676 for this suggestion. It's still a breaking change, but I agree that it is a cleaner, more powerful option.

[karellm]

Closing in favour of #676