Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: include all src files when running yarn coverage #586

Merged
merged 1 commit into from Jun 3, 2022

Conversation

Laityned
Copy link

@Laityned Laityned commented Jun 3, 2022

Why am I submitting this PR

#583

Does it fix an existing ticket?

Yes #583

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #586 (b3ccef8) into master (cc29d02) will increase coverage by 95.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #586       +/-   ##
===========================================
+ Coverage        0   95.32%   +95.32%     
===========================================
  Files           0       11       +11     
  Lines           0     1624     +1624     
===========================================
+ Hits            0     1548     +1548     
- Misses          0       76       +76     
Impacted Files Coverage Δ
src/parser.js 100.00% <0.00%> (ø)
src/lexers/jsx-lexer.js 98.06% <0.00%> (ø)
src/lexers/base-lexer.js 96.29% <0.00%> (ø)
src/lexers/html-lexer.js 100.00% <0.00%> (ø)
src/lexers/vue-lexer.js 100.00% <0.00%> (ø)
src/helpers.js 100.00% <0.00%> (ø)
src/lexers/javascript-lexer.js 96.48% <0.00%> (ø)
src/index.js 100.00% <0.00%> (ø)
src/transform.js 88.30% <0.00%> (ø)
src/lexers/handlebars-lexer.js 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc29d02...b3ccef8. Read the comment docs.

@Laityned Laityned changed the title Fix: include all src files when running yarn coverage WIP: Fix: include all src files when running yarn coverage Jun 3, 2022
@Laityned Laityned changed the title WIP: Fix: include all src files when running yarn coverage Fix: include all src files when running yarn coverage Jun 3, 2022
@karellm
Copy link
Member

karellm commented Jun 3, 2022

Thanks!

@karellm karellm merged commit 36237b1 into i18next:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants