fix: count keys for each namespace instead of global #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I've merged it but it introduces new bugs since now duplicates are not taken into account. I will fix that and deploy a new version soon. |
|
This is fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
When using the verbose option, keys are counted globally while presented as if it is per file. This merge request make sure that statistics are given for each namespace
Does it fix an existing ticket?
Yes,
As a side effect of the incorrect count for the number of unique/plural keys the fail-on-update bug as described in #489 is not working correctly. This should now be fixed too.
Checklist
yarn test(see details here)