Fix trans parsing of spaces #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a `{" "}` is a common pattern when a string is broken into
multiple lines (for example by prettier). But having that extra string
in the component caused the lexer to return the wrong identifier for
following tags leading to i18next not displaying the string correctly.
karellm
force-pushed
the
master
branch
2 times, most recently
from
d72e758
to
10f3d69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
Adding a
{" "}is a common pattern when a string is broken into multiple lines in a react component (for example by prettier). But having that extra string in the component caused the lexer to return the wrong identifier for following tags leading to i18next (20.6.1) not displaying the string correctly.There are other ways of solving this and I'm not sure if this way is the best, happy to change to another fix if requested!
Does it fix an existing ticket?
No
Checklist
yarn test(see details here)